Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix posting reproducibility index to PR #897

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix posting reproducibility index to PR #897

merged 1 commit into from
Apr 23, 2020

Conversation

tiziano88
Copy link
Collaborator

@tiziano88 tiziano88 commented Apr 23, 2020 •
edited
Loading

The current version does not work because when running on merge events
the PR number is not present, so we need to look it up based on commit
SHA.

Ref #861

@tiziano88 tiziano88 force-pushed the tzn_repro_post branch 12 times, most recently from c72f318 to b9bed83 Compare April 23, 2020 11:32
@tiziano88
Fix posting reproducibility index to PR
cbc78f6 
The current version does not work because when running on merge events
the PR number is not present, so we need to look it up based on commit
SHA.

Ref project-oak#861
@tiziano88 tiziano88 requested a review from rbehjati April 23, 2020 11:34
@tiziano88 tiziano88 marked this pull request as ready for review April 23, 2020 11:34
rbehjati
rbehjati approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@rbehjati rbehjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Cannot wait to see it in action.

@tiziano88 tiziano88 merged commit 89cb694 into project-oak:master Apr 23, 2020
@tiziano88
Copy link
Collaborator Author

🤞

@tiziano88 tiziano88 deleted the tzn_repro_post branch April 23, 2020 12:39
@github-actions
Copy link

Reproducibility index:

b872c022d6cd4aeec687d276fbff8d0a66a12e99f0b45a563f1284244dd09510  ./target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
9869e2191b330526dbd4426badc3d1f81e41daba5f2975e5cdcf6e2365f10b8c  ./target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
12105ce8f1aba6f19dd40017f85f3598092f70e095d96c14db7bc531d7c81322  ./target/wasm32-unknown-unknown/release/aggregator.wasm
5ce16b592e32565edcbd9e3b9f37bd5e7a8914238b04762af2ef93926e884dd2  ./target/wasm32-unknown-unknown/release/chat.wasm
2679da47beede6f13953f4b897f221b069159f45461ba988d728affab6db7c9d  ./target/wasm32-unknown-unknown/release/hello_world.wasm
3fc642ca976775d25822b83786cd5836ae24ee0b0ee9145891e3925cc8147e4c  ./target/wasm32-unknown-unknown/release/machine_learning.wasm
a40178bfd10fa2f6d9bdca99a1e0e91f2c201348c11847b69b9e82f9e386a6a1  ./target/wasm32-unknown-unknown/release/private_set_intersection.wasm
d9ed04be4a0894fa988a8c40ad1c036e0c8f73dced0ec54b281a8636e10680b6  ./target/wasm32-unknown-unknown/release/running_average.wasm
313e2dae951a34a66d1a6e8c7c902f74f4fe2541d6f01c1678b65027a608cc88  ./target/wasm32-unknown-unknown/release/translator.wasm
097de181dd94f6c91b9abfbd78d64ea98acf653c4881db98069fbab764ebaf4b  ./target/x86_64-unknown-linux-musl/release/oak_loader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbehjati rbehjati rbehjati approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiziano88 @rbehjati @googlebot